Fix linter and associated tasks #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Intend to merge even with some .md errors occurring in the checks. Intend to fix these in the near future (read: completely eradicate by shifting everything to .mdx) with the audit going on on the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily fixes #827. This involved removing the package
eslint-plugin-react-hooks, which seemed to cause the problems dependency-wise. This enables us to use eslint 9.x.x (with the help of@eslint/compat, which I re-added), whilst also retaining our existing plugins.Getting the linter to work properly again meant there were a lot of linter errors to address. I initially addressed these with Prettier, and resolved a few JS/JSX issues as well. But then realised Prettier erased our adherence to <100 character line limits, so adjusted the
proseWrapsetting in.prettierrctoalways, so that it enforces the best-practice 80 character line length (a value it retrieves from.editorconfig.